Changeset 12938

Timestamp:

09/22/09 00:49:31 (4 years ago)

Author:

BrainSlayer

Message:

more save

File:

• src/router/httpd/modules/broadcom.c (modified) (3 diffs)

src/router/httpd/modules/broadcom.c

@@ -2130 +2130 @@
         if (sscanf(query, "%u-%u", &month, &year) != 2)
                 return;
+        if (month<1 || month>12)
+                return;
 
         days = daysformonth(month, year);
@@ -2140 +2142 @@
         char *tdata = nvram_safe_get(tq);
 
-        if (tdata != NULL || strlen(tdata)) {
+        if (tdata != NULL && strlen(tdata)) {
                 foreach(var, tdata, next) {
                         if (i == days)
                                 break;  //skip monthly total
-                        sscanf(var, "%lu:%lu", &rcvd[i], &sent[i]);
+                        int ret = sscanf(var, "%lu:%lu", &rcvd[i], &sent[i]);
+                        if (ret!=2)
+                            break;
                         totin += rcvd[i];
                         totout += sent[i];
@@ -2167 +2171 @@
         char incom[32];
 
-        sprintf(incom, "%s", live_translate("status_inet.traffin"));
+        snprintf(incom,32, "%s", live_translate("status_inet.traffin"));
         char outcom[32];
 
-        sprintf(outcom, "%s", live_translate("status_inet.traffout"));
+        snprintf(outcom,32, "%s", live_translate("status_inet.traffout"));
         char monthname[32];
 
-        sprintf(monthname, "%s", live_translate(months[month - 1]));
+        snprintf(monthname,32, "%s", live_translate(months[month - 1]));
 
         websWrite(stream,