UPnP daemon memory leak and crash

[LOM]

The current UPnP daemon runs for 17-18 minutes when servicing 6 requests per second (Win XP, alg.exe the Application Layer Gateway). The virtual memory size used by the daemon increases with ~6Kb per second during the time the daemon is up.

The UPnP daemon does not honour the request KEEP-ALIVE, it closes the connection after each request it has serviced. The client application can therefore not use POST to continue communicating, it has to open a new connection. This leaves a lot of CLOSE-WAIT connections in the router.

[frater]

I hope this will get some attention...

[BrainSlayer]

sounds like your service misses to close the connection and this will increase the memory usage for sure every time you open a connection without closing it.

[BrainSlayer]

i hope its fixed with r12291

[Blazian]

Your fix did nothing for us BS, it actually made it worse. I no longer see UPnP working at all on the web GUI in build 12291.

[Blazian]

Please reverse 12291 UPnP fix.

[LOM]

Thanks for the effort BS, here is some additional and hopefully better info for you:

The 6 requests per second from the ApplicationGatewayLayer? monitor program are:

1. GetStatusInfo? (ConnectionStatus?, ConnectionError?, UpTime?)
2. GetTotalBytesSent?
3. GetTotalBytesReceived?
4. GetTotalPacketsSent?
5. GetTotalPacketsReceived?
6. GetCommonLinkProperties? (WANAccessType, LayerUpstreamMaxBitRate?, LayerDownStreamMaxBitRate?, PhysicalLinkStatus?)

and it is GetStatusInfo? that causes VSZ to grow. I have used UPnP tester from www.noeld.com, VSZ grows with 4Kb each time I request WANIPConnection/GetStatusInfo. 4Kb per second during 17 minutes = 4100 Kb and that is also what I see in the top command. The daemon starts with VSZ ~1800Kb and crashes with VSZ ~5900Kb.

The request LANHostConfigManagement/GetReservedAddresses crashes the daemon immediately so you may want to either remove that capability or fix it.

The request LANHostConfigManagement/GetDNSServers replies with NewDNSServers, I am using dnsmasq as local dns server so expected to get the routers address. I can't find the variable lan_dns or lan%d_dns in the nvram..

[LOM]

Maybe close the file *fp in upnp_osl_wan_uptime()