Opened 4 weeks ago

Last modified 2 weeks ago

#5875 reopened

A driver to drastically improve routing performance

Reported by: Paul Owned by:
Keywords: Cc:

Description

There is a way to double-triple routing performance without hardware nat accelerators.

There is an open source Qualcomm driver called Shortcut Forwarding Engine that works on top of kernel network stack and thus on all architectures.

Implementation in k3.18 - chain of commits in https://chromium-review.googlesource.com/c/361050/13

Original source 1 - https://source.codeaurora.org/quic/qsdk/oss/lklm/shortcut-fe/log/?h=release/endive_cc Original source 2 - https://source.codeaurora.org/quic/le/platform/vendor/qcom-opensource/shortcut-fe/log/?h=master

Those original sources seem to be decentralized so commits should be picked from both of them. The Chromium patchset implementation contains better integration into common linux network stack but takes not the most recent snapshot of driver itself.

So imo the best option is to take work on integrating the driver from chromium and take the driver itself from those 2 original repos.

This driver doubles-triples NAT performance. Discussion with performance benchmarking: https://forum.lede-project.org/t/qualcomm-fast-path-for-lede

Change History (11)

comment:1 Changed 2 weeks ago by BrainSlayer

Resolution: toovague
Status: newclosed

this patch adds hooks for the QCA SFE engine. however. the SFE engine is not included in this patch

comment:2 Changed 2 weeks ago by BrainSlayer

found a compatible patch. but according to lede users its causing problems with pppoe

comment:3 Changed 2 weeks ago by BrainSlayer

Resolution: toovague
Status: closedreopened

comment:4 Changed 2 weeks ago by BrainSlayer

Resolution: fixed
Status: reopenedclosed

comment:5 Changed 2 weeks ago by diogosena

Replying to BrainSlayer:

found a compatible patch. but according to lede users its causing problems with pppoe

That PPPOE problem is related to "MSS clamping" which was disabled by default in those LEDE builds, not a fastpath problem.

Last edited 2 weeks ago by diogosena (previous) (diff)

comment:6 Changed 2 weeks ago by diogosena

Resolution: fixed
Status: closedreopened

comment:7 Changed 2 weeks ago by BrainSlayer

okay. i implemented it, enhanced the patch a little bit. working so far on a wrt3200acm and a x64 device

comment:8 Changed 2 weeks ago by Paul

Brainslayer, I suppose you have taken the chromium version of this driver, it's outdated.

Like in 1st post I said I it's better to take the driver from: Original source 1 - ​https://source.codeaurora.org/quic/qsdk/oss/lklm/shortcut-fe/log/?h=release/endive_cc Original source 2 - ​https://source.codeaurora.org/quic/le/platform/vendor/qcom-opensource/shortcut-fe/log/?h=master It has wifi offload support and QoS fixes. Note that mentioned 2 sources are different branches of same driver, so fixes should be merged into 1.

comment:9 in reply to:  8 ; Changed 2 weeks ago by tatsuya46

Replying to Paul:

Brainslayer, I suppose you have taken the chromium version of this driver, it's outdated.

Like in 1st post I said I it's better to take the driver from: Original source 1 - ​https://source.codeaurora.org/quic/qsdk/oss/lklm/shortcut-fe/log/?h=release/endive_cc Original source 2 - ​https://source.codeaurora.org/quic/le/platform/vendor/qcom-opensource/shortcut-fe/log/?h=master It has wifi offload support and QoS fixes. Note that mentioned 2 sources are different branches of same driver, so fixes should be merged into 1.

is it verified by anyone yet that qos uplink AND downlink are working with that one? cause currently downlink is broken completely

comment:10 in reply to:  9 ; Changed 2 weeks ago by mrjcd

Replying to tatsuya46:

Replying to Paul:

Brainslayer, I suppose you have taken the chromium version of this driver, it's outdated.

Like in 1st post I said I it's better to take the driver from: Original source 1 - ​https://source.codeaurora.org/quic/qsdk/oss/lklm/shortcut-fe/log/?h=release/endive_cc Original source 2 - ​https://source.codeaurora.org/quic/le/platform/vendor/qcom-opensource/shortcut-fe/log/?h=master It has wifi offload support and QoS fixes. Note that mentioned 2 sources are different branches of same driver, so fixes should be merged into 1.

is it verified by anyone yet that qos uplink AND downlink are working with that one? cause currently downlink is broken completely

up/down both working fine now w/r32668 using EA8500
Tested after nvram erase. HTB/FQ_Codel, HTB/PIE, HFSC/PIE working.

comment:11 in reply to:  10 Changed 2 weeks ago by tatsuya46

Replying to mrjcd:

Replying to tatsuya46:

Replying to Paul:

Brainslayer, I suppose you have taken the chromium version of this driver, it's outdated.

Like in 1st post I said I it's better to take the driver from: Original source 1 - ​https://source.codeaurora.org/quic/qsdk/oss/lklm/shortcut-fe/log/?h=release/endive_cc Original source 2 - ​https://source.codeaurora.org/quic/le/platform/vendor/qcom-opensource/shortcut-fe/log/?h=master It has wifi offload support and QoS fixes. Note that mentioned 2 sources are different branches of same driver, so fixes should be merged into 1.

is it verified by anyone yet that qos uplink AND downlink are working with that one? cause currently downlink is broken completely

up/down both working fine now w/r32668 using EA8500
Tested after nvram erase. HTB/FQ_Codel, HTB/PIE, HFSC/PIE working.

it still doesnt work with it, its just now that qos enabled = sfe disabled automatically (instead of the user having to disable it manually), once qos is on all sfe issues go away since it stops running, its just like before it was added in this case

u can do a reboot with qos on, then look as lsmod command, no sfe driver listed. turn off qos, reboot again, sfe driver will appear in lsmod.

Last edited 2 weeks ago by tatsuya46 (previous) (diff)
Note: See TracTickets for help on using tickets.