HFSC QoS script sets uplink wrong

dont try to analyse these scripts if you dont know how they are working

I guess that's why you just corrected one of the mistakes then, because I just don't understand it? The HFSC script has major problems and if you didn't read then link then here's the evidence plain and simple.

Here's my classes with up 384kbps / down 1536 kbps.

root@DD-WRT:~# tc class show dev imq0
class hfsc 1: root
class hfsc 1:1 parent 1: sc m1 0bit d 0us m2 100000Kbit ul m1 0bit d 0us m2 100000Kbit
class hfsc 1:100 parent 1:1 leaf 100: ls m1 100000Kbit d 100.0ms m2 100000Kbit ul m1 0bit d 0us m2 100000Kbit
class hfsc 1:10 parent 1:1 leaf 10: rt m1 0bit d 6.1ms m2 307000bit ls m1 0bit d 9.0ms m2 1152Kbit ul m1 0bit d 0us m2 1536Kbit
class hfsc 1:20 parent 1:1 leaf 20: rt m1 0bit d 7.5ms m2 460000bit ls m1 0bit d 9.6ms m2 1152Kbit ul m1 0bit d 0us m2 1536Kbit
class hfsc 1:30 parent 1:1 leaf 30: rt m1 324328bit d 37.0ms m2 153000bit ls m1 0bit d 21.4ms m2 768000bit ul m1 0bit d 0us m2 1536Kbit
class hfsc 1:40 parent 1:1 leaf 40: ls m1 153000bit d 500.0ms m2 153000bit ul m1 0bit d 0us m2 1382Kbit

root@DD-WRT:~# tc class show dev eth1
class hfsc 1: root
class hfsc 1:1 parent 1: sc m1 0bit d 0us m2 100000Kbit ul m1 0bit d 0us m2 100000Kbit
class hfsc 1:100 parent 1:1 leaf 100: ls m1 100000Kbit d 100.0ms m2 100000Kbit ul m1 0bit d 0us m2 100000Kbit
class hfsc 1:10 parent 1:1 leaf 10: rt m1 0bit d 6.1ms m2 307000bit ls m1 0bit d 9.0ms m2 1152Kbit ul m1 0bit d 0us m2 1536Kbit
class hfsc 1:20 parent 1:1 leaf 20: rt m1 0bit d 7.5ms m2 460000bit ls m1 0bit d 9.6ms m2 1152Kbit ul m1 0bit d 0us m2 1536Kbit
class hfsc 1:30 parent 1:1 leaf 30: rt m1 324328bit d 37.0ms m2 153000bit ls m1 0bit d 21.4ms m2 768000bit ul m1 0bit d 0us m2 1536Kbit
class hfsc 1:40 parent 1:1 leaf 40: ls m1 153000bit d 500.0ms m2 153000bit ul m1 0bit d 0us m2 1382Kbit

Line 637 and 639 clearly show that ul_val and dl_val are being passed in a different order to each script.

http://svn.dd-wrt.com:8000/dd-wrt/browser/src/router/services/networking/wshaper.c?rev=11938#L637

Here's a corrected HFSC script.

http://phuzi0n.googlecode.com/svn/trunk/svqos.hfsc

I have the same problem as phuzi0n. I fixed it with a custom script to correct for the ppp0 interface. \

Please don't ignore this bug.